Skip to content

Remove DSPFilters and update URL for EmotiBit_Brainflow_SpO2_Algorithm #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove DSPFilters and update URL for EmotiBit_Brainflow_SpO2_Algorithm #6757

wants to merge 4 commits into from

Conversation

jaketheduque
Copy link
Contributor

  • https://github.com/EmotiBit/EmotiBit_DSPFilters has been removed
  • https://github.com/EmotiBit/BrainflowSpO2Algorithm has been changed to https://github.com/EmotiBit/EmotiBit_Brainflow_SpO2_Algorithm

@github-actions GitHub Actions
Copy link
Contributor

Hi @jaketheduque
A problem was found with your pull request:

❌ ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot added the topic: invalid Request could not be processed label Aug 11, 2025
@github-actions github-actions bot requested a review from per1234 August 11, 2025 23:16
@github-actions GitHub Actions
Copy link
Contributor

Hi @jaketheduque.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed the request for review from per1234 August 11, 2025 23:19
@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: invalid Request could not be processed labels Aug 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/EmotiBit/EmotiBit_Brainflow_SpO2_Algorithm:

Linting library in EmotiBit_Brainflow_SpO2_Algorithm
WARNING: Missing category field in library.properties                                                          
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP037)                                                                                          
WARNING: Missing architectures field in library.properties                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP043)                                                                                          
WARNING: library.properties depends field item(s) Arduino_DSPFilters not found in the Library Manager index.   
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP048)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

@github-actions github-actions bot requested a review from per1234 August 11, 2025 23:19
@jaketheduque jaketheduque mentioned this pull request Aug 11, 2025
Open
12 tasks
per1234
per1234 reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jaketheduque. Please add a comment here on the pull request thread that provides a detailed explanation for why you wish to remove the "EmotiBit DSPFilters" library.

We do remove libraries on request, but I find it strange that you are requesting a removal after you previously requested a name change (#6620). This makes me think that your true goal is not actually the permanent removal of the library, but instead that you plan to remove and then re-add the library in order to accomplish the rename via a hacky approach instead of by following the standard procedure. That is not allowed and would not be productive anyway. We only allow removal requests when the intent is the permanent removal of the library.

Once I understand what your true goal is, I will be happy to assist with that.

Please also avoid mashing different types of requests together into the same pull request. Doing so can make the requests more difficult for us to deal with. We have an automated system that facilitates the management of the registry. That system is designed to work with pull requests that perform a single type of operation (e.g., submission, removal, URL change) and can not handle pull requests that propose multiple types of operations.

@per1234 per1234 self-assigned this Aug 12, 2025
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@per1234 per1234

Labels
status: waiting for information More information must be provided before work can proceed topic: modification Change existing list entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaketheduque @per1234